Automated code review before patch submission. Use when user says: 提交前检查, pre-submit review, submit review, 提交检查, review before push, 自动审查, auto review, check before commit, 检查后提交, submit with review, push with review, or when commit-helper skill is about to push a patch.
How this skill is triggered — by the user, by Claude, or both
Slash command
/rtos-engineer-toolkit:pre-submit-reviewThe summary Claude sees in its skill listing — used to decide when to auto-load this skill
Automatically review code quality before patch submission. Runs as a gate — issues must be resolved or explicitly waived before push.
Automatically review code quality before patch submission. Runs as a gate — issues must be resolved or explicitly waived before push.
Read .claude/rtos-knowledge/coding-style.md and .claude/rtos-knowledge/conventions.md. If not found, invoke project-init first.
This skill activates:
commit-helper skill is about to push (integrated gate)Determine what will be submitted:
# If commit exists (reviewing before push)
git diff <base-branch>...HEAD
# If changes are staged (reviewing before commit)
git diff --cached
Ask user to confirm which commits/changes to review if ambiguous.
Read checker from .claude/rtos-knowledge/coding-style.md:
Read format from .claude/rtos-knowledge/conventions.md:
<module>: <subject>)Output a structured report:
## Pre-Submit Review Report
### Summary
- Files changed: N
- Insertions: +X, Deletions: -Y
- Issues found: A Block / B Major / C Minor / D Nit
### Blocking Issues (must fix)
1. [file:line] <description>
**Fix:** <suggestion>
### Major Issues (should fix)
1. [file:line] <description>
**Fix:** <suggestion>
### Minor Issues (consider fixing)
...
### Style Issues
...
### Commit Message
- Format: ✓/✗
- Content: ✓/✗
- Issue ID: ✓/✗
- Sign-off: ✓/✗ (if required)
### Verdict: PASS / NEEDS FIX / WAIVABLE
Based on the report:
| Verdict | Action |
|---|---|
| PASS | No blocking/major issues. Inform user they can proceed with push. |
| NEEDS FIX | Blocking issues exist. List them. Do NOT proceed until fixed. |
| WAIVABLE | Only major/minor issues. Ask user: fix now, or waive and submit? |
If user waives issues, add a note to the commit message or task record.
commit-helper for pushThe following can be auto-fixed (with user confirmation):
Things that require manual fix:
When commit-helper is about to push, it should invoke this skill as a gate:
commit-helper Step 5 (Push):
→ Run pre-submit-review
→ If PASS/WAIVED: proceed with push
→ If NEEDS FIX: stop, show issues, wait for user
npx claudepluginhub kaben123/rtos-engineer-toolkit --plugin rtos-engineer-toolkitGuides creation, editing, and verification of skills for AI coding agents using test-driven development with subagent scenarios. Use when authoring or debugging skills.