Simplify: Code Review and Cleanup
Review all changed files for reuse, quality, and efficiency. Fix any issues found.
Phase 1: Identify Changes
Run git diff, or git diff HEAD if there are staged changes. If there are no git changes, review the most recently modified files that the user mentioned or that were edited earlier in the conversation.
Phase 2: Review in Three Passes
If the active Codex instructions allow subagents, launch three review agents in parallel and pass each one the full diff. If subagents are unavailable or not allowed, perform the same three passes locally.
Pass 1: Code Reuse Review
For each change:
- Search for existing utilities and helpers that could replace newly written code. Look for similar patterns elsewhere in the codebase. Common locations are utility directories, shared modules, and files adjacent to the changed ones.
- Flag any new function that duplicates existing functionality. Suggest the existing function to use instead.
- Flag any inline logic that could use an existing utility, such as hand-rolled string manipulation, manual path handling, custom environment checks, ad-hoc type guards, and similar patterns.
Pass 2: Code Quality Review
Review the same changes for hacky patterns:
- Redundant state: state that duplicates existing state, cached values that could be derived, observers/effects that could be direct calls
- Parameter sprawl: adding new parameters to a function instead of generalizing or restructuring existing ones
- Copy-paste with slight variation: near-duplicate code blocks that should be unified with a shared abstraction
- Leaky abstractions: exposing internal details that should be encapsulated, or breaking existing abstraction boundaries
- Stringly-typed code: using raw strings where constants, enums, string unions, or branded types already exist in the codebase
- Unnecessary JSX nesting: wrapper Boxes/elements that add no layout value. Check if inner component props such as
flexShrink or alignItems already provide the needed behavior.
- Nested conditionals: ternary chains, nested if/else, or nested switch blocks 3+ levels deep. Flatten with early returns, guard clauses, a lookup table, or an if/else-if cascade.
- Unnecessary comments: comments explaining what the code does, narrating the change, or referencing the task/caller. Delete those. Keep only non-obvious why comments for hidden constraints, subtle invariants, or workarounds.
Pass 3: Efficiency Review
Review the same changes for efficiency:
- Unnecessary work: redundant computations, repeated file reads, duplicate network/API calls, N+1 patterns
- Missed concurrency: independent operations run sequentially when they could run in parallel
- Hot-path bloat: new blocking work added to startup or per-request/per-render hot paths
- Recurring no-op updates: state/store updates inside polling loops, intervals, or event handlers that fire unconditionally. Add a change-detection guard so downstream consumers are not notified when nothing changed. If a wrapper function takes an updater/reducer callback, verify it honors same-reference returns or the local no-change signal.
- Unnecessary existence checks: pre-checking file/resource existence before operating. Operate directly and handle the error.
- Memory: unbounded data structures, missing cleanup, event listener leaks
- Overly broad operations: reading entire files when only a portion is needed, loading all items when filtering for one
Phase 3: Fix Issues
Aggregate findings and fix each actionable issue directly. If a finding is a false positive or not worth addressing, note it and move on.
When done, briefly summarize what was fixed, or confirm the code was already clean.