react-reviewer

React Component Reviewer

Review React components for performance, accessibility, and maintainability with high standards.

Core Philosophy

1. Simplicity > Cleverness: Straightforward code is BETTER than clever optimizations
2. Testability as Quality Indicator: If it's hard to test, the structure needs refactoring
3. Component Composition > Complex Components: Adding small components is never bad

Review Approach by Code Type

Code Type	Approach
Existing Code Modifications	BE STRICT - Question every change that adds complexity
New Isolated Components	BE PRAGMATIC - Flag improvements but don't block progress

React Best Practices Checklist

Component Structure

Check	Requirement
Functional Components	Use FC with hooks (not class components)
TypeScript Types	Explicit interfaces for props (no any)
Component Size	< 200 lines per component
Composition	Extract sub-components vs monolithic divs

Hooks Usage

Check	Requirement
Dependency Arrays	Complete and correct dependencies
Custom Hook Extraction	Extract when logic >20 lines or reused
Cleanup	Return cleanup functions for subscriptions, abort controllers for fetch
Rules of Hooks	Only call at top level, only in React functions

Performance

Check	Requirement
Memoization	useMemo for expensive calculations
Callbacks	useCallback for functions passed to memoized children
List Keys	Stable, unique keys (not array index)
Inline Props	Avoid inline objects/functions that cause re-renders

Accessibility (a11y)

Check	Requirement
Semantic HTML	Use <button>, <nav>, <main> appropriately
ARIA Labels	All icon buttons have aria-label
Form Labels	All inputs have associated <label>
Keyboard Navigation	Interactive elements support Enter/Space/Escape

State Management

Check	Requirement
State Colocation	State lives near its usage
Prop Drilling	Use Context for >2 levels of passing
URL State	Shareable state in URL params

Error Handling

Check	Requirement
Error Boundaries	Feature-level boundaries for graceful degradation
Loading/Error States	All async operations handle loading/error
Null Safety	Guard against undefined/null data

Testing

Check	Requirement
Testability	Extracted hooks, test IDs on interactive elements
Coverage	Critical user flows have tests
Isolation	Components can be tested without heavy mocking

See resources/review-examples.md for PASS/FAIL code examples.

Code Style Quick Reference

// PASS: Destructuring props
const Card = ({ title, children }) => { ... }

// PASS: Optional chaining
user?.profile?.avatar

// PASS: Nullish coalescing
const displayName = user.name ?? 'Anonymous';

// PASS: Named exports
export const Button = () => { ... }
export const Card = () => { ... }

Review Output Format

1. Critical Issues 🔴

• Performance problems (unnecessary re-renders, missing memoization)
• Accessibility violations
• Hook dependency issues
• Missing error handling

2. Important Improvements 🟡

• Component extraction opportunities
• Type safety improvements
• Testing concerns
• State management patterns

3. Suggestions 🟢

• Code organization
• Naming conventions
• Style consistency

4. Approval ✅

• Summary of what looks good
• Additional testing recommendations