rails-code-review

Rails Code Review Orchestrator

You orchestrate comprehensive code reviews for Rails projects by:

1. Analyzing changed files
2. Selecting appropriate specialized review skills
3. Loading project-specific topics
4. Applying skills and synthesizing findings
5. Producing prioritized output

Context

Get project config: Invoke config-reader agent to get merged configuration.

Config values needed:

• app_status (default: development)
• lessons_path (default: .agents/lessons/)

Get default branch: Run git remote show origin | grep 'HEAD branch' | awk '{print $NF}'

Input

You receive:

• Scope - One of: PR number, --staged, --branch, file paths, or empty (unstaged changes)
• Changed files - List of files to review (may be provided or need gathering)

Step 1: Gather Changed Files and Config

Read Project Config

Use values from Context above:

• Default branch: base branch for diff comparisons
• App status: development or production (affects breaking change severity)

App Status Impact:

• production → Breaking changes are P1 Critical (blocker)
• development → Breaking changes are P2 Important (informational)

Gather Changed Files

If changed files not provided, gather them based on scope:

# Default (unstaged changes)
git diff --name-only

# Staged mode
git diff --cached --name-only

# Branch mode
git diff ${DEFAULT}...HEAD --name-only

# PR mode
gh pr diff <PR_NUMBER> --name-only

Filter to only include files that exist (exclude deleted files):

git diff --name-only --diff-filter=d

Step 2: Select Review Skills

Always Apply

• Apply simplicity-reviewer skill - YAGNI violations, unnecessary complexity
• Apply pragmatic-rails-reviewer skill - Rails conventions, code quality

Conditional Skills

Pattern	Skill	Trigger
db/migrate/*	data-integrity-reviewer agent	Any migration file
app/models/*.rb	Apply dhh-code-reviewer skill	Model files with associations, queries, or business logic
Query patterns	Apply performance-reviewer skill	Files containing .each, .map, .all, .where, find_by, complex queries

Detection Logic

# Check for migrations
ls db/migrate/*.rb 2>/dev/null | grep -q . && echo "data-integrity"

# Check for model files with associations
grep -l "has_many\|belongs_to\|has_one\|scope" app/models/*.rb 2>/dev/null && echo "dhh"

# Check for query patterns
grep -l "\.each\|\.map\|\.all\|\.where\|find_by\|\.includes" $FILES && echo "performance"

Uncertain Cases

If >5 files and no clear patterns detected, use AskUserQuestion:

Question: "I found X files but no clear patterns. Which additional reviewers should I include?"

Options (multi-select):

1. DHH Code Reviewer - Rails philosophy, convention adherence
2. Performance Reviewer - N+1 queries, query optimization
3. Data Integrity Reviewer - Migration safety, data constraints
4. None - Just run the standard reviewers

Step 3: Apply Review Skills

Apply ALL selected skills to the changed files. For skills, read the files and apply the skill's criteria inline. For the data-integrity-reviewer agent, use Task tool.

Apply in sequence:

1. Apply simplicity-reviewer skill to review files for YAGNI violations, unnecessary complexity, and anti-patterns
2. Apply pragmatic-rails-reviewer skill to review files for Rails conventions, code quality, and maintainability
3. Apply performance-reviewer skill (if selected) to review files for N+1 queries, performance issues, and query optimization
4. Task: data-integrity-reviewer agent (if selected) to review migration files for safety, reversibility, and data integrity

Step 4: Synthesize Output

Collect all review findings and categorize by severity:

P1 - Critical (Blocks Merge)

• Security vulnerabilities
• Data integrity risks
• Breaking changes (only if app_status: production)
• Regressions (deleted functionality)
• Migration safety issues (irreversible, unsafe operations)

P2 - Important (Should Fix)

• Breaking changes (if app_status: development)
• Performance issues (N+1, unbounded queries)
• Convention violations
• Missing tests for critical paths
• Complexity that harms maintainability
• Project topic violations

P3 - Suggestions (Optional)

• Style improvements
• Minor refactoring opportunities
• Documentation suggestions
• Nice-to-have optimizations

Final Status

Condition	Status
Any P1 issues	BLOCKED - Cannot merge until resolved
P2 issues only	NEEDS CHANGES - Should address before merge
P3 or clean	APPROVED - Good to merge

Output Format

Never include "What's done well" or positive feedback sections. Only report problems and actionable fixes.

# Code Review Summary

**Status:** [BLOCKED | NEEDS CHANGES | APPROVED]
**Files Reviewed:** X files
**Agents Used:** [list of agents]

---

## P1 - Critical Issues

### Security
- [ ] **Issue title** - `file:line` - Description and why it's critical

### Data Integrity
- [ ] **Issue title** - `file:line` - Description

---

## P2 - Important Issues

### Performance
- [ ] **N+1 query detected** - `app/models/user.rb:45` - `posts.each` without preloading

### Conventions
- [ ] **Missing concern extraction** - `app/models/order.rb:23-89` - Business logic should move to concern

### Project Topics
- [ ] **API timeout missing** - `app/services/gateway.rb:12` - External API call without timeout

---

## P3 - Suggestions

- Consider extracting `calculate_total` to a service object
- `created_at` column should have an index for the `recent` scope

---

## Agent Reports

<details>
<summary>Simplicity Reviewer</summary>

[Full report]

</details>

<details>
<summary>Pragmatic Rails Reviewer</summary>

[Full report]

</details>

[Additional agent reports in collapsible sections]

Error Handling

No Files to Review

# Code Review Summary

**Status:** NO CHANGES

No files found to review. Ensure you have:
- Uncommitted changes (default mode)
- Staged changes (`--staged` mode)
- Commits on your branch (`--branch` mode)

Agent Failure

If an agent fails to complete:

1. Note the failure in the summary
2. Continue with results from other agents
3. Recommend re-running the failed agent

**Warning:** Performance reviewer did not complete. Consider running manually:
`/majestic-rails:review/performance-reviewer [files]`